Use npm scripts #42
Merged
Use npm scripts #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,15 @@ | |||
| { | |||
| //"validateIndentation": 2, index.js uses 2, and tests.js uses 4. https://github.com/jscs-dev/node-jscs/issues/1106 | |||
There was a problem hiding this comment.
I don't know if you want to normalize your indentation. If you do, I'll be happy to give it a whack.
| "files": [ | ||
| "index.js", | ||
| "releases/" | ||
| ], |
There was a problem hiding this comment.
This is what files are included when doing npm install deep-diff. I don't know if releases/ needs to be there. If you npm install you can set a version, and you probably minify yourself.
Comparison: http://imgur.com/X754Cwp,GIS3QPq
flitbit
pushed a commit
that referenced
this pull request
Oct 18, 2015
Use npm scripts; good all-around cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This is mostly making use of
npm'sscriptfeature. It now lints before running tests, and you can uglify usingnpm run uglify. This should make theMakefileredundant, but I kept it in in case you prefer that. 😄 It also removes a dependency on a globaluglifyjs.I saw you also had
indent-checking in JSHint. This isn't supported anymore (http://stackoverflow.com/a/23098280/1850276), so I added JSCS as a replacement for it.