Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make sure all isolates start during flutter driver tests." #62239

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

jonahwilliams
Copy link
Member

Reverts #61841

Numerous devicelab tests are broken by this change, specifically new_gallery_ios_transition_perf. It is not clear from the logs what is going wrong

@fluttergithubbot fluttergithubbot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jul 25, 2020
@jonahwilliams
Copy link
Member Author

Landing to fix build

@speaking-in-code
Copy link
Contributor

@jonahwilliams I can take a swing at fixing the devicelab tests. Is there documentation on how to run them?

@acoutts
Copy link

acoutts commented Aug 4, 2020

Could this be related? I can only run my driver test about 50% of the time. When it fails, the app hangs at the initial splash screen (before dart isolate runs), and the log says this when I run on android:

I/flutter ( 8128): Observatory listening on http://127.0.0.1:33085/6hDv8THcFWg=/
E/FlutterFcmService( 8128): Fatal: failed to find callback
00:00 +0: Bottlepay app SkSL warmup (setUpAll)

VMServiceFlutterDriver: Connecting to Flutter application at http://127.0.0.1:58315/6hDv8THcFWg=/
VMServiceFlutterDriver: Isolate found with number: 1476990802004759
VMServiceFlutterDriver: Isolate is paused at start.
VMServiceFlutterDriver: Attempting to resume isolate
VMServiceFlutterDriver: Connected to Flutter application.
Unexpected <collected> sentinel.

VMServiceFlutterDriver: waitForCondition message is taking a long time to complete...

And it's dead at this point until I uninstall the app and try again.

I am using the "IsolatesWorkaround" and Flutter 1.21.0-1.0.pre:

    // Connect to the Flutter driver before running any tests.
    setUpAll(() async {
      driver = await FlutterDriver.connect();
      workaround = IsolatesWorkaround(driver);
      await workaround.resumeIsolates();
      await driver.waitUntilFirstFrameRasterized();
    });

    // Close the connection to the driver after the tests have completed.
    tearDownAll(() async {
      if (driver != null) {
        await driver.close();
        await workaround.tearDown();
      }
    });

Using print statements I found it's hanging on await driver.waitUntilFirstFrameRasterized();.

Edit
After doing a flutter clean, removing the entire pub_cache directory, uninstalling the app from the device and trying again, I got it to work again.

@guidezpl
Copy link
Member

guidezpl commented Aug 4, 2020

@acoutts Looks like it to me. Follow #24703 for updates

Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants