-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Make sure all isolates start during flutter driver tests." #62239
Conversation
Landing to fix build |
@jonahwilliams I can take a swing at fixing the devicelab tests. Is there documentation on how to run them? |
Could this be related? I can only run my driver test about 50% of the time. When it fails, the app hangs at the initial splash screen (before dart isolate runs), and the log says this when I run on android:
And it's dead at this point until I uninstall the app and try again. I am using the "IsolatesWorkaround" and // Connect to the Flutter driver before running any tests.
setUpAll(() async {
driver = await FlutterDriver.connect();
workaround = IsolatesWorkaround(driver);
await workaround.resumeIsolates();
await driver.waitUntilFirstFrameRasterized();
});
// Close the connection to the driver after the tests have completed.
tearDownAll(() async {
if (driver != null) {
await driver.close();
await workaround.tearDown();
}
}); Using print statements I found it's hanging on Edit |
…utter#61841)" (flutter#62239) This reverts commit 5fa5701.
…utter#61841)" (flutter#62239) This reverts commit 5fa5701.
Reverts #61841
Numerous devicelab tests are broken by this change, specifically new_gallery_ios_transition_perf. It is not clear from the logs what is going wrong