This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] Remove the custom analysis options, fix failing lints. #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing lints. The custom analysis_options was excluding the lint for documenting all public methods. So this PR mostly adds Dartdocs, however there are a few non Dartdoc changes: * example/lib/main.dart: make MyApp and kAutoConsume private. * lib/src/in_app_purchase/app_store_connection.dart: adds a @VisibleForTesting AppStoreConnection constructor. * lib/src/in_app_purchase/app_store_connection.dart: adds a @VisibleForTesting AppStoreConnection.observer getter.
|
"Windows Plugins" was fixed and the re-run is green (the presubmit indicator is stale). |
This was referenced Oct 29, 2020
amirh
added a commit
that referenced
this pull request
Oct 29, 2020
Follow-up for #3220 (forgot to bump in that PR).
yasargil
added a commit
to yasargil/plugins
that referenced
this pull request
Oct 30, 2020
* master: (48 commits) [video_player] Add toString() to Caption (flutter#3233) [google_maps_flutter_web] Show one InfoWindow at a time. (flutter#3224) [in_app_purchase] Bump version (flutter#3227) [google_maps_flutter] Overhaul lifecycle management in GoogleMapsPlugin (flutter#3213) [in_app_purchase] Remove the custom analysis options, fix failing lints. (flutter#3220) [video_player]Fixes Playing video from asset on Android (flutter#3123) [camera] Added documentation about video not working correctly on Android emulators (flutter#3180) Revert "update api" update api [wifi_info_flutter] Method channel name fixed for android (flutter#3207) [share] Fix bug on iPad where `origin` is null and enable XCUITests in the repo (flutter#3210) [google_maps_flutter] Clean up google_maps_flutter plugin (flutter#3206) Exclude generated_plugin_registrant.cc (flutter#3198) broaden the constraint on package:vm_service (flutter#3208) Remove unnecessary work around from test in prep for vm_service migration (flutter#3209) Add windows directory to examples (flutter#3149) [video_player] Upgrade ExoPlayer (flutter#3204) [android_alarm_manager] Removed deprecated display1 (flutter#3200) [Connectivity] wifi removal (flutter#3173) [wifi_info_flutter] make it ready for initial 1.0.0 release (flutter#3191) ...
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…ts. (flutter#3220) The custom analysis_options was excluding the lint for documenting all public methods. So this PR mostly adds Dartdocs, however there are a few non Dartdoc changes: * example/lib/main.dart: make MyApp and kAutoConsume private. * lib/src/in_app_purchase/app_store_connection.dart: adds a @VisibleForTesting AppStoreConnection constructor. * lib/src/in_app_purchase/app_store_connection.dart: adds a @VisibleForTesting AppStoreConnection.observer getter.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Follow-up for flutter#3220 (forgot to bump in that PR).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom analysis_options was excluding the lint for documenting all public methods.
So this PR mostly adds Dartdocs, however there are a few non Dartdoc changes: