Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure checker issue 10 #21

Draft
wants to merge 49 commits into
base: dev
Choose a base branch
from
Draft

Structure checker issue 10 #21

wants to merge 49 commits into from

Conversation

lyubolp
Copy link
Contributor

@lyubolp lyubolp commented Mar 23, 2025

No description provided.

lyubolp added 30 commits March 2, 2025 22:46
@lyubolp
First version of the structure check
fe08d08
@lyubolp
Add StructureCheck to checks factory and update check instantiation
c282bf5
@lyubolp
Add strcture check config and file
ba49f35
@lyubolp
Add option to skip virtual environment creation in CLI
af7976d
@lyubolp
Add TODOs for handling scored and non-scored checks in AbstractCheck
5844835
@lyubolp
Refactor StructureCheck to improve structure validation and enhance e…
98e9801 
…rror handling
@lyubolp
Add TODO for supporting multiple structures in StructureCheck
6a87d45
@lyubolp
Add TODO to improve virtual environment creation logic
232b240
@lyubolp
Enhance StructureCheck with detailed docstrings for improved code cla…
e06c1ef 
…rity and maintainability
@lyubolp
Refactor AbstractCheck to support generic types and enhance check exe…
9d6a668 
…cution logic; add ScoredCheck and NonScoredCheck implementations.
@lyubolp
Refactor checks to extend ScoredCheck instead of AbstractCheck for im…
ef493cd 
…proved scoring functionality
@lyubolp
Update check initializers to require is_venv_required parameter for i…
0c991c5 
…mproved virtual environment handling
@lyubolp
Refactor StructureCheck to extend NonScoredCheck and update run metho…
11c9db8 
…d to return boolean for structure validation
@lyubolp
Remove max_points and requires_venv parameters from check creation fo…
b8943c2 
…r simplified check initialization
@lyubolp
Remove TODO comments regarding scoring and StructureCheck parameters …
380ce8e 
…in AbstractCheck
@lyubolp
Update requirements.txt
c8c70e0
@lyubolp
Refactor check execution to use check_result instead of check_score a…
9a1f752 
…nd update score logging for ScoredCheck instances
@lyubolp
Change console handler to use sys.stdout for logging output
652d45b
@lyubolp
Add first functional tests
6f027e1
@lyubolp
Enhance functional tests to include student ID handling and configura…
79e1460 
…tion support
@lyubolp
Add functional tests for logging and project path validation
68d45db
@lyubolp
Refactor functional tests to remove decorator for repository cloning …
7b61a83 
…and implement setup/teardown methods
@lyubolp
Rename functional test methods for consistent numbering
54c33e2
@lyubolp
Add configuration files for various check setups with point allocations
18c95a5
@lyubolp
Add functionality documentation outlining grading features and requir…
aec8c24 
…ements
@lyubolp
Add error handling for non-existent project root directory
919e91d
@lyubolp
Refactor test commands in justfile to separate unit and functional tests
12741f4
@lyubolp
Update GitHub Actions workflow to separate unit and functional test e…
7c1f92a 
…xecutions
@lyubolp
Merge pull request #19 from fmipython/functional-tests
c5a29fe 
Functional tests
@lyubolp
Merge branch 'main' into structure-checker-issue-10
164ad70
lyubolp added 19 commits March 18, 2025 08:52
@lyubolp
Refactor constructor parameters in coverage, pylint, requirements, an…
792374d 
…d type hints checks
@lyubolp
Rename 'requires_venv' to 'is_venv_required' in configuration files a…
d330a41 
…nd update related logic
@lyubolp
Fix DummyCheck instantiation by correcting parameter type for second …
0fab530 
…argument
@lyubolp
Add validation for 'is_venv_required' in check configuration
6fd7729
@lyubolp
Rename test methods for clarity and add validation for missing 'is_ve…
94115bf 
…nv_required' in checks
@lyubolp
Add validation for expected keys in check configuration
4a403ea
@lyubolp
Refactor test setup to correct parameter order and add 'is_venv_requi…
38f82e8 
…red' flag
@lyubolp
Add 'skip_venv_creation' key to expected arguments in get_args tests
419b65f
@lyubolp
Refactor file search functions to use StructureValidator for improved…
010701e 
… file matching
@lyubolp
Refactor StructureCheck to utilize StructureValidator and streamline …
97407b0 
…structure validation
@lyubolp
Add unit tests for CoverageCheck class in test_structure_check module
ab00dec
@lyubolp
Add StructureValidator class and unit tests for validation logic
a1e104c
@lyubolp
Refactor justfile to improve test commands and add clean targets
7a63a1b
@lyubolp
Update file resolution in StructureValidator to return absolute paths
626c5cd
@lyubolp
Enhance unit tests for StructureValidator to verify correct file matc…
5798614 
…hing logic
@lyubolp
Update tests to use StructureValidator for file matching and adjust a…
1505182 
…ssertions
@lyubolp
Remove functional tests from the repository to prevent issues and red…
1ac499d 
…uce execution time
@lyubolp
Refactor pylint_check to use files module for finding Python files
cd291fe
@lyubolp
Refactor functional tests to use a base class and improve setup/teard…
e20ffbc 
…own logic
@lyubolp lyubolp requested a review from yalishanda42 March 23, 2025 20:36
@lyubolp lyubolp marked this pull request as draft March 23, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yalishanda42 yalishanda42 Awaiting requested review from yalishanda42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lyubolp