-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metapackages: pkg_config
backend support; HDF5
#1055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henilp105
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @perazz , looks good to me.
Will merge soon if there are no outstanding comments |
Thanks @perazz , let's get this merged ! |
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup-fortran
actiongfortran
only)-standard-semantics
from default flags: it changes module name mangling from_mp_
to_MP_
which crashes linking against external libraries (HDF5 but also MPI-code can not be built with Intel compiler when using standard flags #1034)HDF5 comes with compiler wrappers (
h5fc
,h5cc
,h5cxx
). These are often unreliable.For example, they do not work when the library is built with CMake for Homebrew.
So, do like meson: get hdf5 information via pkg-config.
To achieve that, implement a pkg-config backend for the metapackages.
cc: @henilp105 @arteevraina @awvwgk @gnikit @fortran-lang/fpm