Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gauss_legendre with interval #619

Closed
mjben opened this issue Jan 13, 2022 · 4 comments · Fixed by #660
Closed

gauss_legendre with interval #619

mjben opened this issue Jan 13, 2022 · 4 comments · Fixed by #660
Labels
bug Something isn't working easy Difficulty level is easy and good for starting into this project

Comments

@mjben
Copy link

mjben commented Jan 13, 2022

Description

Unless I missed something, there should not be x(1) = interval(1) and x(size(x)) = interval(2) in gauss_legendre subroutines, this would only be relevant for gauss_legendre_lobatto.

Expected Behaviour

gauss_legendre(x, w, interval=[-1._dp, 1._dp] should give same result as without interval optional.

Version of stdlib

0.1.0

Platform and Architecture

Linux

Additional Information

No response

@mjben mjben added the bug Something isn't working label Jan 13, 2022
@ivan-pi
Copy link
Member

ivan-pi commented Jan 14, 2022

@hsnyder, can you comment on this issue?

The classic Gauss-Legendre quadrature indeed doesn't have nodes at the interval endpoints.

@hsnyder
Copy link
Contributor

hsnyder commented Jan 14, 2022

mjben is correct, this is an error. Feel free to fix it if either of you want to, otherwise I will can do so over the weekend.

@jvdp1
Copy link
Member

jvdp1 commented Apr 23, 2022

mjben is correct, this is an error. Feel free to fix it if either of you want to, otherwise I will can do so over the weekend.

Has this bug been fixed?

@14NGiestas 14NGiestas added the easy Difficulty level is easy and good for starting into this project label May 5, 2022
@hsnyder
Copy link
Contributor

hsnyder commented May 23, 2022

@mjben @ivan-pi @jvdp1 I've opened a pull request to fix this issue. Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy Difficulty level is easy and good for starting into this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants