Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix erroneous gaussian quadrature points in gauss_legendre #660

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Fix erroneous gaussian quadrature points in gauss_legendre #660

merged 2 commits into from
Jun 13, 2022

Conversation

hsnyder
Copy link
Contributor

@hsnyder hsnyder commented May 23, 2022

fixes #619

jvdp1
jvdp1 approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@jvdp1 jvdp1 requested review from ivan-pi and a team May 23, 2022 12:07
milancurcic
milancurcic approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you, I left one suggestion for change.

@milancurcic
Copy link
Member

Thanks! Will merge.

@milancurcic milancurcic merged commit d110944 into fortran-lang:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milancurcic milancurcic milancurcic approved these changes

@jvdp1 jvdp1 jvdp1 approved these changes

@ivan-pi ivan-pi Awaiting requested review from ivan-pi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gauss_legendre with interval
3 participants
@hsnyder @milancurcic @jvdp1