Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use pip to install cmake #123

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Do not use pip to install cmake #123

merged 1 commit into from
Jan 23, 2020

Conversation

certik
Copy link
Member

@certik certik commented Jan 23, 2020

Fixes #122.

Rather install the binary directly.

Fixes fortran-lang#122.
@certik
Copy link
Member Author

certik commented Jan 23, 2020

The CMake installation sped up from 11s to 3s on Linux. I am going to merge this, so that the other PRs start passing.

@certik certik merged commit c4f81f7 into fortran-lang:master Jan 23, 2020
@certik certik deleted the cmake branch January 23, 2020 22:57
@certik
Copy link
Member Author

certik commented Jan 23, 2020

@zbeekman you might want to have a look at this. The Python way to install it failed, so I switched to a simple binary.

P.S. It took me over 1h to figure out how to properly do that ---- the usual way of extracting the tarball and creating a symlink in /usr/local/bin completely failed ("broken symlink") but I don't have more time to investigate. The above way works for now.

@zbeekman
Copy link
Member

zbeekman commented Jan 23, 2020 via email

@zbeekman
Copy link
Member

LGTM. I typically use the self-extracting script rather than a tarball, but this seems like a perfectly good approach, and, apparently, CMake is already the latest version on macOS I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: CMake fails to install on macOS
2 participants