Added complex to io #138
Merged
Added complex to io #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
certik
requested changes
Feb 2, 2020
|
Support for complex. No reformatting. |
jvdp1
requested changes
Feb 3, 2020
There was a problem hiding this comment.
Thank you @fiolj for these improvements. I have mainly minor revisions.
Could you also update stdlib_experimental_io.md, please (to mention that it supports complex numbers)?
Also, could you, please, remove the file stdlib_experimental_io.f90 from the list
set(SRC
stdlib_experimental_ascii.f90
stdlib_experimental_io.f90
stdlib_experimental_error.f90
stdlib_experimental_kinds.f90
stdlib_experimental_optval.f90
stdlib_experimental_system.F90
${outFiles}
)in src/CMakelists.txt (it should have been removed sooner I guess)?
|
Changed files along the lines suggested by @jvdp1 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of support for complex number in io
Note that I had to change the function
number_of_rows_numeric()