Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement loadtxt and savetxt #23
Implement loadtxt and savetxt #23
Changes from 3 commits
65d8d59
7a7ca5f
9d0d3aa
8d33ead
43ed837
eff8a6f
559bfd7
5e9565e
57d517f
65301b9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdlib_ascii
module will be useful here to not use literal constants. Minot nitpick as ascii constants won't change any time soon, but nevertheless.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally didn't expose
whitechar
as public, as we might want to change the API. Once we implementstdlib_string
we can put all these in it and polish it up.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a "circular dependency" here. I would like to submit a pull request for
stdlib_ascii
but I was waiting to have some CMake machinery set up and so I could useassert
in the unit tests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internally in
stdlib_ascii
I am also using both literal character and hexadecimal constants for the symbols in the ascii table. I see no other portable way. Of course compiler vendors targeting specific processors with other default collating sequences could implement their own low-level versions. I guess another option would be to hack something up using thetransfer
intrinsic and bit-mask operations, but I see no benefit.Edit: probably I misunderstood your comment, which was implying to use something like
char == ascii_tab .and. char == ascii_space
instead of cryptic ascii sequence integers. Thestdlib_ascii
module will have ais_blank
function, which can be used instead ofwhitechar
.