Write a more verbose introduction to building stdlib #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
awvwgk
commented
Jan 7, 2021
awvwgk
commented
- explicitly spell out the requirements on compilers, build system and preprocessor
- add a short paragraph on how to install the build dependencies using pip or conda
- explain the CMake build step by step
- list all important CMake configuration options in the README
- add the CMake install command to the build instructions
- move the paragraph about the max array rank into the build instructions
- explicitly spell out the requirements on compilers, build system and preprocessor - add a short paragraph on how to install the build dependencies using pip or conda - explain the CMake build step by step - list all important CMake configuration options in the README - add the CMake install command to the build instructions - move the paragraph about the max array rank into the build instructions
Co-authored-by: Milan Curcic <[email protected]>
- list combinations tested in the GH actions CI - list reported failing compilers
jvdp1
reviewed
Jan 11, 2021
Co-authored-by: Jeremie Vandenplas <[email protected]>
|
With no further suggestions, I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.