Portable savetxt and loadtxt #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2021
* Port test_open.f90 to test-drive * Port test_parse_mode.f90 to test-drive * Port test_savetxt.f90 to test-drive * Port test_savetxt_qp.f90 to test-drive * Port test_loadtxt.f90 to test-drive * Add complex data test to test_loadtxt.f90 * Port test_loadtxt_qp.f90 to test-drive * Clean all test artifacts in Makefile.manual * Fix error handling in test_loadtxt * Don't reuse output file names between tests
…of_rows() to make ifort happy
|
Sounds good. I'll close this PR and open against your branch in #494. The latest 2 commits expand the round-trip tests for tiny and huge numbers. These tests revealed a few more issues--one leading to a small fix in |
|
Closing in favor of awvwgk#90. |
|
I am struggling to review this, I see 51 changed files... That's too much. Can we do one clean PR to port to a new test framework system (but do no other changes), and then send clean PRs with changes unrelated to the testsuite change? |
|
@certik I added a comment for the recommended review process in #494 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements specific formats to use in
savetxtandloadtxt, and improves the tests to compare exact values and not just approximates.It depends on tests in #494, so this should be rebased to master after #494 is merged. Or is there a better strategy for this, @awvwgk? The tests in awvwgk#87 need this fix to pass. Should this fix go there instead?
Fixes #505.