-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on no tests in CTest #588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was used to test the oldest supported CMake version, but the minimum required CMake version is 3.14. Maybe the original Ubuntu image 16.04 or 18.04 did not have a sufficiently new CMake version preinstalled? |
Yes, it could be that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the CMake version was pinned to ensure that there were no breaking changes for the minimum required version, but I can't be sure. The changes to the CI all look fine to me. What is the motivation here? i.e. what situation would cause CMake to not find any tests?
I have no idea why CMake didn't find the tests. I observed it for several actions, and then seemed to work fine again... |
Two approvals... I'll merge this PR. Thank you @awvwgk |
We are currently pinning CMake to version 3.16 in our CI, which doesn't allow to raise an error in case CTest doesn't find any tests. Unless there is a particular reason to test with CMake 3.16, we can use this PR to use the preinstalled CMake 3.22 version.
Closes #587