Update changelog #590
Merged
Update changelog #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awvwgk
added
documentation
jvdp1
approved these changes
Dec 6, 2021
|
We document it in the contributing guide and workflow docs. There we should ask for 1) tests, 2) specs, and 3) changelog update for all feature PRs. |
|
Added a sentence to the contributing guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we require every PR to add an entry to the changelog as well? This way we avoid a lot of work collecting those before a new release and also keep the changelog an up-to-date source of new features in stdlib.
Note: I just realized I should have added the npy format to the changelog after I hit the merge button