Extension of PR#679 to stdlib_stats_distribution_exponential
#717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ossible, otherwise explicit impure
jvdp1
reviewed
Jun 8, 2023
|
Not yet, but I've realized that shortcoming. I started started fixing it for normal and I will do so for exponential. |
…/stdlib into stats-distribution-exponential
|
For the sake of clarity, the question raised above by @jvdp1 has been addressed with the last batch of commits. From my perspective, this PR is ready for review. |
jvdp1
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to #679 for an explanation about the issue to solve and approach used. As discussed there, I've extended the approach to the exponential module.
IMO, this module still has other opportunities for improvement. For instance, I don't understand why
rvs_exp_array_does not call the corresponding scalar procedurervs_exp_, but instead repeats the code inrvs_exp_0_. I will have a better look at it and, eventually, suggest another PR.