-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to include int32 hashmap keytype #778
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
65bdc89
Update to include int32 hashmap keytype
chuckyvt 418cb82
Update src/stdlib_hashmap_wrappers.f90
chuckyvt 561cee2
Update stdlib_hashmap_wrappers.f90
chuckyvt f10f1b7
Bug fix
chuckyvt 7cf7352
Minor comment cleanup
chuckyvt 35ed826
Update stdlib_hashmaps.md
chuckyvt 1724a4f
Merge branch 'master' into hashmap_int32_key
chuckyvt cb53f85
Add character and int32 keytype tests
chuckyvt fe3fffc
Update test_maps to include key types
chuckyvt fab4a21
Update test/hashmaps/test_maps.fypp
chuckyvt 9b80107
Update test_maps.fypp
chuckyvt 9ebb0c2
Merge branch 'hashmap_int32_key' of https://github.com/chuckyvt/stdli…
chuckyvt 822b5c9
stdlib_hashmap_wrappers and test_maps.fypp
chuckyvt f35386f
Update test_maps.fypp
chuckyvt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I wonder whether it matters that
value
is unallocated in the RHS call totransfer
(since it will be deallocated on input if allocated)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've asked this question at fortran discourse here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for asking. Intuitively it seems like it shouldn't matter since its only pulling type info, not size. But I also did a quick search and didn't come up with anything. We could hardcode it to [0_int8], but I don't like that quite as much.