Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use fortran-setup for GCC, Intel LLVM and Intel Classic #834

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Jun 9, 2024

This PR replaces the manual setup of GCC, Intel LLVM and Intel Classic in our CI via the setup-fortran GA workflow.
The motivation behind this is to remove a lot of the maintenance cost + also pin the Intel compiler versions.
This PR should allow us to extend CI testing with the nvidia compilers and with more modern versions of macos on arm64.

Additional notes

I have disabled the GCC-13 + Macos-12 run since there appears to be failing due to ld linker errors stemming from the gcc cask.

@gnikit gnikit force-pushed the ci/setup-fortran branch from e65ef08 to d91e933 Compare June 9, 2024 13:59
@gnikit gnikit marked this pull request as ready for review June 9, 2024 15:27
@gnikit gnikit changed the title ci: use fortran-setup for GCC version testing ci: use fortran-setup for GCC, Intel LLVM and Intel Classic Jun 9, 2024
@gnikit gnikit requested review from perazz, jvdp1 and a team June 9, 2024 16:12
@gnikit gnikit linked an issue Jun 9, 2024 that may be closed by this pull request
@gnikit
Copy link
Member Author

gnikit commented Jun 9, 2024

This PR would supersede #833

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is much cleaner now.

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gnikit . This looks much cleaner and easier to maintain!

@gnikit gnikit merged commit 627d72c into master Jun 10, 2024
33 checks passed
@gnikit gnikit deleted the ci/setup-fortran branch June 10, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macos-12 builds failing again
4 participants