Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support csv file reading and writing in loadtxt and savetxt. #958

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Support csv file reading and writing in loadtxt and savetxt. #958

wants to merge 6 commits into from

Conversation

zoziha
Copy link
Contributor

@zoziha zoziha commented Mar 20, 2025 •
edited
Loading

Description

This PR will add a delimiter argument to loadtxt and savetxt functions for issue #948 to support potential CSV data file support.

Additionally, it corrects the title errors of stdlib_math and stdlib_sparse docs.

@zoziha zoziha linked an issue Mar 20, 2025 that may be closed by this pull request
Suggest that loadtxt supports reading CSV files of pure floating-point type, that is, add a argument delimiter to savetxt and loadtxt interfaces. #948
Open
jvdp1
jvdp1 approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @zoziha

perazz
perazz reviewed Mar 21, 2025
View reviewed changes
Copy link
Member

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @zoziha, I also think that this is about ready to merge. I only have a couple comments.

@zoziha
Copy link
Contributor Author

zoziha commented Mar 21, 2025 •
edited
Loading

@jvdp1, @perazz Thanks for your review.

There is a bug that made me dig deep into the reason and it took a long time. I once mentioned in #532 that the combination of form="formatted" and access="stream" in the stdlib_io.open function will lead to a bug in gfortran. But this time I also encountered this problem in ifort. You can refer to the CI failure. For safety, I think form="formatted" should better be combined with access="sequential".

Therefore, I have changed this internal detail to the open function.

@zoziha zoziha linked an issue Mar 21, 2025 that may be closed by this pull request
[Help] Maybe a bug that will affect stdlib_io:open: open files with access=stream in gfortran. #532
Open
perazz
perazz approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @zoziha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalvesz jalvesz jalvesz left review comments

@perazz perazz perazz approved these changes

@jvdp1 jvdp1 jvdp1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@zoziha @perazz @jvdp1 @jalvesz