Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections for OOP article #526

Open
Beliavsky opened this issue Feb 20, 2025 · 8 comments
Open

Corrections for OOP article #526

Beliavsky opened this issue Feb 20, 2025 · 8 comments

Comments

@Beliavsky
Copy link
Contributor

I or someone should submit a PR -- just noting these as I see them.

At https://fortran-lang.org/learn/oop_features_in_fortran/object_based_programming_techniques/ "programmers intentions" should be "programmer's intentions", and "especially" should be capitalized.

"create a copy of an object and then getting rid of the original" should be "create a copy of an object and then get rid of the original" to maintain a consistent verb tense

@henilp105
Copy link
Member

Please Feel Free to Submit a PR , It would be great to have them !

nbehrnd added a commit to nbehrnd/fortran-lang_webpage that referenced this issue Feb 28, 2025
A correction based on Beliavsky's reading.[1]

[1] fortran-lang#526

Signed-off-by: Norwid Behrnd <[email protected]>
nbehrnd added a commit to nbehrnd/fortran-lang_webpage that referenced this issue Feb 28, 2025
A correction based on Beliavsky's reading.[1]

[1] fortran-lang#526

Signed-off-by: Norwid Behrnd <[email protected]>
@nbehrnd
Copy link
Contributor

nbehrnd commented Feb 28, 2025

@henilp105 To account for the suggestions by @Beliavsky, I just tried to file a PR. Each time I observe an initial admission, later a technical rejection, for instance

Image

either after a local edit in my fork (with a git sparse checkout, i.e., only the files relevant to the booklet of OOP), or with the GitHub based edit/creation of a branch in the browser by period / .

Question: is it an error on my side, or perhaps a (temporary) question of the original GitHub repository's set up? The later seems a possibility because the link behind contributing on the landing page currently does not work.

@henilp105
Copy link
Member

henilp105 commented Mar 2, 2025

@nbehrnd I'm not sure, but most likely seems to be a GitHub bug, that got resolved on its own. On my side it can be merged, does it still show as the above ?

Regarding the contributing landing page has a redirection bug, we would have missed to add a redirection to that page.

@AliHaider332
Copy link

@henilp105 This PR corrects minor grammatical inconsistencies and improves readability in the Object-Based Programming Techniques documentation. The changes ensure better clarity and maintain a professional tone. Please review and let me know if any further refinements are needed. Thanks!

@nbehrnd
Copy link
Contributor

nbehrnd commented Mar 2, 2025

@henilp105 On today's revisit of the PR filed, it looks like the issue is gone and the page states the expected "a merge is up to the owners/maintainers of the original repository".

Maybe GitHub proposes a workflow slightly different to the one previously in place; note the line "try the new merge experience" (bottom right of the screen photo)

Image

and a click could activate either one of two update modes:

Image

So far, I did not engage with / clicked on either option because I presume this is going to work well only for a PR by an author with administrative privileges about the original GitHub repository. I didn't apply for such an extension because of too little knowledge on my side how fortran-lang.org as a web site is set up (and why parameters are set the way they are) plus the great benefit of a second read/technical review regarding Fortran before a PR is merged.

Because this PR addresses each of the issues identified by @Beliavsky, to me, it looks like the next step is a merge by one with these extended privileges.

@nbehrnd
Copy link
Contributor

nbehrnd commented Mar 2, 2025

@AliHaider332 Earlier last week, there was a suggestion/request to save/mirror a Wikipedia article about Fortran 95, see here. I started to convert it into a multipage booklet for the learning section. While this isn't completed yet, may I ping you later for a second read once it is ready e.g., a typo not recognized, inconsistency in style, etc. prior to filing the PR?

@henilp105
Copy link
Member

@nbehrnd both the options imply to update your fork's branch to latest main, can can be applied by you (as the owner of fork).

I have built a preview of the changes which you can use to see how the changes look.

@nbehrnd
Copy link
Contributor

nbehrnd commented Mar 2, 2025

@henilp105 So it is just an embellished button to run git pull ... From my side, it is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants