Build and utilize pre-compiled binaries #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2022
pbrisbin
changed the title
pbrisbin
commented
Dec 8, 2022
pbrisbin
commented
Dec 8, 2022
pbrisbin
requested review from
a team and
z0isch
and removed request for
a team
pbrisbin
commented
Dec 8, 2022
pbrisbin
commented
Dec 8, 2022
eborden
reviewed
Dec 8, 2022
eborden
reviewed
Dec 8, 2022
Comment on lines
+11
to
+29
| GHCs = %W[ | ||
| 9.2.5 | ||
| 9.2.4 | ||
| 9.2.3 | ||
| 9.2.2 | ||
| 9.0.2 | ||
| 9.0.1 | ||
| 8.10.7 | ||
| 8.10.6 | ||
| 8.10.5 | ||
| 8.10.4 | ||
| 8.10.3 | ||
| 8.10.2 | ||
| 8.10.1 | ||
| 8.8.4 | ||
| 8.8.3 | ||
| 8.8.2 | ||
| 8.8.1 | ||
| ] |
There was a problem hiding this comment.
Side quest, would it make sense to contribute this matrix to weeder itself and pull binaries from that project?
https://github.com/ocharles/weeder/releases
There was a problem hiding this comment.
@ocharles is using nix, which makes binary caching easy, but I'm not sure the current state of multi GHC builds in that ecosystem.
There was a problem hiding this comment.
I was indeed surprised when I found they weren't there. It's possible needing to have a binary built against the GHC of your project was enough complexity that they punted -- or maybe there's an Actual Reason they'd not want it. I'll probably open an Issue to ask at some point.
Making users wait for a `stack install weeder` is an unnecessary tax on every CI run that lacks a complete cache. Instead, this PR adds an "Binaries" action that builds binaries across a runner/GHC matrix and stores them on a Release for use by the action. The Binaries action is idempotent and has been run and added all the binaries already, which our own CI uses successfully. I made binaries for Linux and Mac and GHCs 8.8.1 to 9.2.5. Windows may be possible, but the `prep` step needs to be rewritten for that platform. These are all the GHC versions for which a released version of `weeder` exists, so it should cover all users. Arguably, these binaries should be released by the weeder project itself. I may open an Issue soon to see if they'd be open to upstreaming something like tooling I have here, which is pretty non-standard due to the need to version by GHC and not by weeder.
This comment was marked as resolved.
This comment was marked as resolved.
pbrisbin
commented
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making users wait for a
stack install weederis an unnecessary tax onevery CI run that lacks a complete cache. Instead, this PR adds an
"Binaries" action that builds binaries across a runner/GHC matrix and
stores them on a Release for use by the action. The Binaries action is
idempotent and has been run and added all the binaries already, which
our own CI uses successfully.
I made binaries for Linux and Mac and GHCs 8.8.1 to 9.2.5. Windows may
be possible, but the
prepstep needs to be rewritten for thatplatform. These are all the GHC versions for which a released version of
weederexists, so it should cover all users.Arguably, these binaries should be released by the weeder project
itself. I may open an Issue soon to see if they'd be open to upstreaming
something like tooling I have here, which is pretty non-standard due to
the need to version by GHC and not by weeder.