This repository was archived by the owner on Apr 15, 2023. It is now read-only.
Add support for exclude: true
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlmn
reviewed
Oct 20, 2020
Co-authored-by: Laxman <[email protected]>
notlmn
reviewed
Oct 20, 2020
|
|
||
| Regex to exclude commits based on their title (don't include the initial and final `/`). | ||
|
|
||
| Setting this to `true` will enable the default preset, which may change over time, but is currently: `/^meta|^document|^lint|^refactor|readme|dependencies|^v?\d+\.\d+\.\d+/i` |
There was a problem hiding this comment.
Wondering if this is going to bite the uses, as the input takes the string form of a regex (without the leading and trainling /). Also as they can not pass in flags for the regex as well.
There was a problem hiding this comment.
I was thinking the same, but it says don't include the initial and final `/`) just in the previous sentence.
There was a problem hiding this comment.
That should be cool then (except for the flag part)
There was a problem hiding this comment.
Yeah the best solution would be to support a full regex instead of just its textual string. Perhaps there’s an app module for that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20