Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update solipsism #12

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Update solipsism #12

merged 1 commit into from
Mar 28, 2024

Conversation

Marenz
Copy link
Contributor

@Marenz Marenz commented Mar 25, 2024 •
edited
Loading

Update solipsism to latest version and use modern way to replace event loop

@Marenz Marenz requested a review from a team as a code owner March 25, 2024 12:03
@Marenz Marenz requested a review from ktickner March 25, 2024 12:03
@Marenz Marenz added the cmd:skip-release-notes It is not necessary to update release notes for this PR label Mar 25, 2024
llucax
llucax reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the starting of the actor, I would add a initialize() function that creates a global Dispatcher/actor object (not for this PR).

@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Mar 27, 2024
@llucax
Copy link
Contributor

llucax commented Mar 27, 2024

Oh, I guess I made a few changes in my PR that were present here. I thought I saw some docs examples being fixed, I think I forgot it was a different PR and was on a sea of catching up so it was hard to keep track and keep everything in my mind, sorry about that. I guess this PR needs some renaming and updating the description. Also, tests are failing :(

@Marenz Marenz changed the title API enhancements Update solipsism Mar 28, 2024
@Marenz
Copy link
Contributor Author

Marenz commented Mar 28, 2024

It wasn't much work, not a problem ;)

Updated description

@Marenz Marenz added this pull request to the merge queue Mar 28, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit f3fdc3e Mar 28, 2024
14 checks passed
@Marenz Marenz deleted the enhancements branch March 28, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llucax llucax llucax approved these changes

@matthias-wende-frequenz matthias-wende-frequenz matthias-wende-frequenz left review comments

@leandro-lucarella-frequenz leandro-lucarella-frequenz leandro-lucarella-frequenz left review comments

@ktickner ktickner Awaiting requested review from ktickner ktickner is a code owner automatically assigned from frequenz-floss/api-dispatch-team

Assignees
No one assigned
Labels
cmd:skip-release-notes It is not necessary to update release notes for this PR part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Marenz @llucax @matthias-wende-frequenz @leandro-lucarella-frequenz