Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix footer #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix footer #49

wants to merge 1 commit into from

Conversation

am9zZWY
Copy link
Member

@am9zZWY am9zZWY commented Jan 23, 2025

Replace position absolute with sticky

@am9zZWY
Fix footer
509a6f4 
Replace position absolute with sticky
@am9zZWY
Copy link
Member Author

am9zZWY commented Jan 23, 2025

@PhictionalOne

@not-a-feature
Copy link
Collaborator

For me, it makes the screen even more crowded.

@am9zZWY
Copy link
Member Author

am9zZWY commented Jan 26, 2025

With absolute:
image

With sticky:
image

@am9zZWY
Copy link
Member Author

am9zZWY commented Jan 26, 2025

For me, it makes the screen even more crowded.

With absolute you have an unwanted floating footer, not only in Safari but also Brave which is Chromium based.
I can see where this came from but I think it's better to use "sticky" here

@not-a-feature
Copy link
Collaborator

Well, this seems to be a known bug in safari...
"A parent with overflow set to auto will prevent position: sticky from working in Safari"

In that case I'm fine with this change

@not-a-feature not-a-feature mentioned this pull request Feb 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@am9zZWY @not-a-feature