Issue 26 #27
Merged
Issue 26 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests used to always mock window and document because the tests were always run in a Node environment, and therefore these objects did not exist. This change lets webpack-amdi18n-loader run in a Node environment by testing for the existence of window/document before attempting to use them.
|
Merged, thanks. I'll release a new version ASAP. |
|
released in 0.9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run in Node without errors
The tests used to always mock window and document because the tests were
always run in a Node environment, and therefore these objects did not
exist.
This change lets webpack-amdi18n-loader run in a Node environment by
testing for the existence of window/document before attempting to use
them.