feat: nestjs-slack plugin #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yasai-T
requested review from
a team,
9renpoto,
yuichkun and
abyssparanoia
and removed request for
a team
9renpoto
reviewed
Mar 13, 2020
example/src/app.module.ts
Outdated
| import { Module } from "@nestjs/common"; | ||
| import { TypeOrmModule } from "@nestjs/typeorm"; | ||
| import { GraphQLModule } from "@nestjs/graphql"; | ||
| import { AppController } from "./app.controller"; | ||
| import { AppService } from "./app.service"; | ||
| import { NodeModule } from "./node/node.module"; | ||
| import { RecipesModule } from "./recipes/recipes.module"; | ||
| import { ConfigModule } from "./config/config.module"; |
There was a problem hiding this comment.
https://docs.nestjs.com/techniques/configuration try use this :)
9renpoto
reviewed
Mar 13, 2020
packages/nestjs-slack/README.md
Outdated
| @@ -0,0 +1 @@ | |||
| TBA | |||
There was a problem hiding this comment.
we recommend standard-readme format :)
This reverts commit 6181a6d.
9renpoto
reviewed
Mar 13, 2020
example/src/app.module.ts
Outdated
|
|
||
| const isProduction = process.env.NODE_ENV === "production"; | ||
|
|
||
| @Module({ | ||
| imports: [ | ||
| ConfigModule.forRoot(), |
There was a problem hiding this comment.
Suggested change
| ConfigModule.forRoot(), | |
| ConfigModule.forRoot({ | |
| ignoreEnvFile: true, | |
| load: [] | |
| }), |
9renpoto
reviewed
Mar 13, 2020
README.md
Outdated
|
|
||
| ## Usage | ||
|
|
||
| cp example/.env.tmpl example/.env |
9renpoto
approved these changes
Mar 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added nestjs-slack webhook plugin