Skip to content

Support React.Fragments. #799 #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2018
Merged

Support React.Fragments. #799 #800

merged 3 commits into from
Jan 19, 2018

Conversation

theKashey
Copy link
Collaborator

Add React.Fragment support. Literally just flatmap children out of the React.Fragment element.
Not to be merged, first I have to investigate why Fragment sometimes works as a host node (children next to instance), and sometimes as a class (children as prop).

@codecov-io
Copy link

codecov-io commented Jan 16, 2018

Codecov Report

Merging #800 into next will increase coverage by 0.28%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #800      +/-   ##
==========================================
+ Coverage   84.95%   85.23%   +0.28%     
==========================================
  Files          22       22              
  Lines         472      481       +9     
  Branches      129      133       +4     
==========================================
+ Hits          401      410       +9     
- Misses         53       59       +6     
+ Partials       18       12       -6
Impacted Files Coverage Δ
...ckages/react-hot-loader/src/internal/reactUtils.js 92.3% <100%> (+11.35%) ⬆️
...-hot-loader/src/reconciler/hotReplacementRender.js 88.54% <90%> (-0.83%) ⬇️
...ot-loader/src/internal/stack/hydrateLegacyStack.js 8.69% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8802f03...7923d79. Read the comment docs.

@theKashey theKashey merged commit 9277095 into next Jan 19, 2018
@gregberge gregberge deleted the support-fragments branch January 22, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants