Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node-pre-gyp dependency #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump node-pre-gyp dependency #25

wants to merge 2 commits into from

Conversation

jure
Copy link

@jure jure commented Sep 6, 2018

As described in #24.

Closes #24.

@jure
Copy link
Author

jure commented Sep 6, 2018

Builds were failing due to an issue with nan that was resolved in 2.11.0: nodejs/nan#766, so I updated that too.

@jure
Copy link
Author

jure commented Sep 6, 2018

This is passing on Node versions > 4 on Travis, but seems to be failing on AppVeyor Node version 5. 🤷‍♂️

@jure
Copy link
Author

jure commented Nov 6, 2018

Both of the failures are not related to the content of this PR:

C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js:85
      let notifier = require('update-notifier')({pkg})
      ^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:148:18)
    at node.js:405:3

Seems like a AppVeyor infrastructure specific thing.

Anyway, this has become an issue again for us, and has previously caused us to delay moving to the latest LTS Node, so we've temporarily published libtidy-updated (it's difficult/impossible to add it as a git dependency, as it has git submodules in there).

Anyone up the chain ready to look at this PR?

@davidbarratt
Copy link

this fixed my problem! thanks!

@pspi
Copy link

pspi commented Dec 28, 2019

This would solve compilation problems with Node v13. Any chance the PR could be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't compile on Node v10.9.0 on macOS.
3 participants