Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md "Explorer context menu" section makes no sense #8

Closed
rjmunro opened this issue Feb 21, 2018 · 0 comments
Closed

README.md "Explorer context menu" section makes no sense #8

rjmunro opened this issue Feb 21, 2018 · 0 comments
Assignees
@gamunu
Labels
bug

Comments

@rjmunro
Copy link

rjmunro commented Feb 21, 2018

Expected Behavior

That the README file would make sense

Actual Behavior

### Explorer context menu

Run npm install, also available in the context menu of the explorer when the `package.json file
  • Why does it talk about npm, not yarn?
  • The sentence doesn't seem to finish.
  • package.json is missing the closing backtick, causing rendering to be inconsistent between github and VSCode.
  • npm install, (presumably meaning yarn install) should probably be backticked too as it is code you normally run in a terminal.
@gamunu gamunu self-assigned this Feb 22, 2018
gamunu pushed a commit that referenced this issue Feb 26, 2018
Fix issues #8 and #9
a858819 
* Fix the bug context menu not correctly picking up the package.json file
* Update readme file
* Add tslint.json
* Add .editorconfig.json
* Fix lint errors
@gamunu gamunu closed this as completed Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gamunu gamunu

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjmunro @gamunu