Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapStore only supports string visibility #3121

Closed
t92549 opened this issue Nov 27, 2023 · 0 comments · Fixed by #3313
Closed

MapStore only supports string visibility #3121

t92549 opened this issue Nov 27, 2023 · 0 comments · Fixed by #3313
Assignees
@rj77259
Labels
bug Confirmed or suspected bug map-store Specific to/touches the map-store module
Milestone
Backlog

Comments

@t92549
Copy link
Contributor

t92549 commented Nov 27, 2023 •
edited by GCHQDeveloper314
Loading

Describe the bug
The MapStore only supports visibility properties of type string. This is because of an incorrect assumption, from this cast:

Gaffer/store-implementation/map-store/src/main/java/uk/gov/gchq/gaffer/mapstore/impl/GetElementsUtil.java

Line 145 in 9d3f452

final ElementVisibility elementVisibility = new ElementVisibility((String) e.getProperty(visibilityProperty));

Expected behaviour
Custom objects should be allowed as well as basic string visibilities.

Additional context
Right now the ApplyViewToElementsFunction uses the MapStore, so this is affecting federation.
@t92549 t92549 added bug Confirmed or suspected bug map-store Specific to/touches the map-store module labels Nov 27, 2023
@GCHQDeveloper314 GCHQDeveloper314 added this to the Backlog milestone Mar 15, 2024
@rj77259 rj77259 self-assigned this Oct 7, 2024
@rj77259 rj77259 linked a pull request Oct 7, 2024 that will close this issue
Gh-3121: MapStore only supports string visibility #3313
Merged
wb36499 added a commit that referenced this issue Oct 14, 2024
@rj77259 @wb36499
Gh-3121: MapStore only supports string visibility (#3313)
ac9c4a7 
* First commit. Fixing bug that would only allow String properties. This commit allows any type of object to be passed.

* Addressing CheckStyle issues.

* Correcting copyright in ElementVisibiliy.

---------

Co-authored-by: wb36499 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rj77259 rj77259

Labels
bug Confirmed or suspected bug map-store Specific to/touches the map-store module
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Gh-3121: MapStore only supports string visibility gchq/Gaffer
3 participants
@t92549 @GCHQDeveloper314 @rj77259