Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

g.E() creates too many Operations #3359

Closed
p29876 opened this issue Jan 28, 2025 · 0 comments · Fixed by #3360
Closed

g.E() creates too many Operations #3359

p29876 opened this issue Jan 28, 2025 · 0 comments · Fixed by #3360
Assignees
@p29876
Labels
bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module
Milestone
2.3.2

Comments

@p29876
Copy link
Member

p29876 commented Jan 28, 2025

Describe the bug
g.E() should map to a single Gaffer OperationChain.
Instead it creates 2n + 1 queries, where n is the number of edges in the graph.

(1) GetAllElements
     For each edge found:
        (2) GetElements(src)
        (3) GetElements(dest)

This is causing unacceptable performance for simple queries
@p29876 p29876 added bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module labels Jan 28, 2025
@p29876 p29876 added this to the 2.3.2 milestone Jan 28, 2025
@p29876 p29876 self-assigned this Jan 28, 2025
p29876 added a commit that referenced this issue Jan 28, 2025
@p29876
gh-3359 Reduce number of vertex lookups for edges
c7440c3 
Stop inV/outV performing a full vertex lookup
Add new methods for doing this when we want to traverse an Edge
@github-actions github-actions bot mentioned this issue Jan 28, 2025
Merged
p29876 added a commit that referenced this issue Jan 29, 2025
@p29876
Merge branch 'develop' into gh-3359-gremlin-edge-query
0c67473
wb36499 pushed a commit that referenced this issue Jan 30, 2025
@p29876
Gh-3359: Reduce number of vertex lookups for edges (#3360)
72aeb9b 
* gh-3359 Reduce number of vertex lookups for edges

Stop inV/outV performing a full vertex lookup
Add new methods for doing this when we want to traverse an Edge

* headers

* tidy and add tests

* javadoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p29876 p29876

Labels
bug Confirmed or suspected bug tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Milestone
2.3.2
Development

Successfully merging a pull request may close this issue.

Gh-3359: Reduce number of vertex lookups for edges gchq/Gaffer
1 participant
@p29876