Skip to content

convert smc_custom_proposal to genstudio (GEN-233) #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: mh/cookbook-smc-visual
Choose a base branch
from

Conversation

mhuebert
Copy link
Contributor

@MathieuHuot

  • I converted the doc to a .py file (LMK if that's ok, I can also convert back to .ipynb).
  • For performance reasons I am saving the logo as an image, and using that in the studio plot using a new Plot.img mark. (Turns out the Observable Plot raster mark is much slower, takes 500ms to render pixels from data.)
  • I converted the logo to an outline so that dots inside/outside are equally visible.
  • requires the latest genstudio version (so be sure to poetry install)
Screen.Recording.2024-09-27.at.5.43.58.PM.mov

@mhuebert mhuebert changed the title convert smc_custom_proposal to genstudio convert smc_custom_proposal to genstudio (GEN-233) Sep 27, 2024
Copy link

linear bot commented Sep 27, 2024

GEN-233 Gen-Studio Visualization for SMC

huebert and mhuot to pair on adding gen-studio to a cookbook page on SMC.

Copy link

codecov bot commented Sep 27, 2024

The author of this PR, mhuebert, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

Copy link
Collaborator

@MathieuHuot MathieuHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @mhuebert, and I think we can merge this version on my branch.
I will continue to develop the project to get to the point I wanted with rejuvenation and different strategies, and then we'll be able to try interactive inference!

@MathieuHuot
Copy link
Collaborator

@mhuebert I notice you still haven't merged this.
I the mean time I rewrote most of the code to make it cleaner and actually work (there were a few math bugs, now it's fixed but SMC looks worse for some reason). I rewrote the jupyter notebook version though, it's what I'm more used to for running cells and debugging.

@mhuebert mhuebert force-pushed the huebert/cookbook-smc-visual-studio branch from 54ea424 to a3099c3 Compare October 21, 2024 14:09
@mhuebert
Copy link
Contributor Author

@MathieuHuot I've revised this PR:

  • changes are applied directly to the .ipynb file
  • I introduced a dots_plot helper fn
    The only thing I'm not sure about are the correct image paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants