Skip to content

Make "mix" tracing addresses customizable (GEN-892) #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sritchie
Copy link
Contributor

Still needs a docs update and tests.

Copy link

linear bot commented Feb 17, 2025

Copy link

gitstream-cm bot commented Feb 17, 2025

🥷 Code experts: femtomc

sritchie, femtomc have most 👩‍💻 activity in the files.
sritchie, femtomc have most 🧠 knowledge in the files.

See details

src/genjax/_src/core/generative/generative_function.py

Activity based on git-commit:

sritchie femtomc
FEB 31 additions & 34 deletions 14 additions & 43 deletions
JAN
DEC 85 additions & 4 deletions
NOV 3 additions & 4 deletions
OCT 181 additions & 89 deletions 2 additions & 10 deletions
SEP 8 additions & 8 deletions 1601 additions & 70 deletions

Knowledge based on git-blame:
femtomc: 80%
sritchie: 17%

src/genjax/_src/generative_functions/combinators/mixture.py

Activity based on git-commit:

sritchie femtomc
FEB 2 additions & 5 deletions
JAN
DEC
NOV
OCT 1 additions & 1 deletions
SEP 9 additions & 7 deletions

Knowledge based on git-blame:
sritchie: 74%

To learn more about /:\ gitStream - Visit our Docs

@MathieuHuot
Copy link
Collaborator

@sritchie great idea! I think it should be customisable as you propose in this PR, and maybe the default should be to add no extra outer address (as if we were using .inline or as Fabian found it we can currently write @ () and get the same effect).
And maybe we could have a little checker at trace time that checks whether addresses are the same in both branches and return the difference as a warning if not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants