Skip to content

move indexed => functional_types [in progress] #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sritchie
Copy link
Contributor

@sritchie sritchie commented Feb 24, 2025

Some thoughts here:

  • I can't kill Indexed now because some folks (SaferData) are using it for their choicemaps.
  • I want it to be that we can are left with a tree of Indexed and Or, with basically anything at the leaves. And I think I want to make sure that the shapes match if someone provides a non-Sparse...
  • the key here is implementing __getitem__ on this structure, so that when you call __getitem__ you descend down into the Indexed or Or layers until you hit a NON-Sparse. At that point you should
    • tree-map the selection down to the bottom
    • is_leaf should block at Mask, since we know those are handled carefully
  • to MAKE these things I want to have extend create a sequence of Indexed, and then Or can | them together
  • choicemap, when the builder receives dynamic addresses, should build one of these things
  • fetching should query down into one of these things (__call__ syntax on the choicemap)

Copy link

gitstream-cm bot commented Feb 28, 2025

🥷 Code experts: no user but you matched threshold 10

sritchie has most 👩‍💻 activity in the files.
sritchie has most 🧠 knowledge in the files.

See details

src/genjax/_src/core/generative/choice_map.py

Activity based on git-commit:

sritchie
FEB 165 additions & 180 deletions
JAN
DEC 17 additions & 0 deletions
NOV 114 additions & 248 deletions
OCT 317 additions & 178 deletions
SEP 1777 additions & 894 deletions

Knowledge based on git-blame:
sritchie: 82%

src/genjax/_src/core/generative/functional_types.py

Activity based on git-commit:

sritchie
FEB 5 additions & 5 deletions
JAN
DEC
NOV 112 additions & 35 deletions
OCT 185 additions & 65 deletions
SEP 91 additions & 157 deletions

Knowledge based on git-blame:
sritchie: 82%

To learn more about /:\ gitStream - Visit our Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant