move indexed => functional_types [in progress] #1534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some thoughts here:
Indexed
now because some folks (SaferData) are using it for their choicemaps.Indexed
andOr
, with basically anything at the leaves. And I think I want to make sure that the shapes match if someone provides a non-Sparse...__getitem__
on this structure, so that when you call__getitem__
you descend down into theIndexed
orOr
layers until you hit a NON-Sparse. At that point you shouldMask
, since we know those are handled carefullyextend
create a sequence ofIndexed
, and thenOr
can | them together__call__
syntax on the choicemap)