Add a simple contract system to the time travel debugger. #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🥷 Code experts: sritchie sritchie, sharlaon have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
fzaiser
reviewed
Mar 17, 2025
|
|
||
|
|
||
| @Pytree.dataclass | ||
| class Breakpoint(Generic[R, S], Pytree): |
| @@ -77,21 +134,15 @@ def _cont_prim_call(brk_pt, *args): | |||
| return initial_style_bind(record_p)(_cont_prim_call)(self, *args) | |||
|
|
|||
|
|
|||
| def rec( | |||
| def brk( | |||
| callable: Callable[..., R], | |||
| debug_tag: str | None = None, | |||
| ): | |||
There was a problem hiding this comment.
Could you add a docstring? For instance, it was unclear to me what callable is used for. First I thought it was the continuation for after the breakpoint, but Breakpoint.handle is already given a continuation.
|
@fzaiser thanks for taking a look! I’ll add a bunch of docstrings and tests and ask for a quick re-review sometime this week / next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.