Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP-145 SQL explain drives rest flow to OIDC endpoint. #146

Merged
merged 1 commit into from
Mar 20, 2025
Merged

HTTP-145 SQL explain drives rest flow to OIDC endpoint. #146

merged 1 commit into from
Mar 20, 2025

Conversation

davidradl
Copy link
Contributor

Description

Change the code so that the OIDC authentication flow is moved to lookup query time. This means that explain select - does not issue a network call.

Resolves http145

PR Checklist

@davidradl davidradl mentioned this pull request Mar 19, 2025
Closed
@davidradl davidradl changed the title http145 SQL explain drives rest flow to OIDC endpoint. HTTP-145 SQL explain drives rest flow to OIDC endpoint. Mar 19, 2025
@davidradl
Copy link
Contributor Author

@grzegorz8 @kristoffSC could you review this one please?

kristoffSC
kristoffSC previously requested changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@kristoffSC kristoffSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
only small comments

@davidradl
Copy link
Contributor Author

LGTM, only small comments

Great thanks @grzegorz8 and @kristoffSC for you prompt reviews - I have made the changes you suggest. Let me know if you see anything more or LGTM!

@davidradl
Copy link
Contributor Author

@grzegorz8 and @kristoffSC it would be great for us if we could get this merged and a release created quickly. Many thanks.

@grzegorz8 grzegorz8 requested a review from kristoffSC March 20, 2025 11:26
@grzegorz8 grzegorz8 dismissed kristoffSC’s stale review March 20, 2025 11:28

Discussions have been resolved. Dismissing review to unblock merge.

@grzegorz8 grzegorz8 merged commit 12945d9 into getindata:main Mar 20, 2025
3 checks passed
@grzegorz8
Copy link
Member

@grzegorz8 and @kristoffSC it would be great for us if we could get this merged and a release created quickly. Many thanks.

Hey! Done.
https://github.com/getindata/flink-http-connector/actions/runs/13968356618
https://repo1.maven.org/maven2/com/getindata/flink-http-connector/0.19.0/

I tried yesterday a few times, but uploads failed due to timeouts. Fortunately, publish pipeline succeeded today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzegorz8 grzegorz8 grzegorz8 approved these changes

@kristoffSC kristoffSC Awaiting requested review from kristoffSC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidradl @grzegorz8 @kristoffSC