Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest): enable profiling tests #40183

Merged
merged 36 commits into from
Nov 7, 2022
Merged

feat(jest): enable profiling tests #40183

merged 36 commits into from
Nov 7, 2022

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Oct 18, 2022

Enable profiling in jest

@JonasBa
Copy link
Member Author

JonasBa commented Oct 18, 2022

Converted to draft as the overhead is too large. I need to identify what is responsible for the timeouts.
Possible reasons to eliminate:

  • ensure jest is not waiting for sendEvent to be done before exiting a test
  • check if kLazyLogging is the culprit and if changing to kEagerLogging would help
  • ??

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2022

size-limit report 📦

Path Size
src/sentry/static/sentry/dist/entrypoints/app.js 20.17 KB (-0.03% 🔽)
src/sentry/static/sentry/dist/entrypoints/sentry.css 33.06 KB (0%)

@JonasBa
Copy link
Member Author

JonasBa commented Oct 21, 2022

This seems much better now with eager logging and most test runs seem to have almost no overhead. That said, in some cases like https://github.com/getsentry/sentry/actions/runs/3285415456/jobs/5428080614, a run takes a few minutes longer to complete and times out.. Our test balancer seems to always have one test run that takes a lot longer than the rest (~15min compared to 10-12 on the other 3)

@JonasBa JonasBa force-pushed the jb/profiling/jest-env branch from 15fd41f to 39106cc Compare October 21, 2022 16:44
Copy link
Member

@Zylphrex Zylphrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JonasBa
Copy link
Member Author

JonasBa commented Nov 7, 2022

image

@JonasBa JonasBa merged commit 66229f9 into master Nov 7, 2022
@JonasBa JonasBa deleted the jb/profiling/jest-env branch November 7, 2022 19:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants