Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(fe): Convert <IntegrationDetailedView /> to FC #86954

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Mar 12, 2025

Last usage of AbstractIntegrationDetailedView, after this is merged we can delete the file entirely 👍

Same as #86699, #86705, and #86895

@leeandher leeandher requested a review from a team March 12, 2025 23:02
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 12, 2025
Comment on lines 20 to +22
export type Tab = 'overview' | 'configurations' | 'features';

interface AlertType extends AlertProps {
export interface AlertType extends AlertProps {
Copy link
Member Author

@leeandher leeandher Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both of these can be moved to integrationLayout.tsx after completing this conversion, since I'll delete this file anyway

@leeandher leeandher changed the title ref(fe): Convert <IntegrationDetailedView /> to FC ref(fe): Convert <IntegrationDetailedView /> to FC Mar 12, 2025
@leeandher leeandher merged commit a96df73 into master Mar 13, 2025
45 checks passed
@leeandher leeandher deleted the leander/fc-integrationDetailedView branch March 13, 2025 13:43
leeandher added a commit that referenced this pull request Mar 13, 2025
Removing since it's no longer used 🎊 

First Refactor  - #86656
DocIntegrationDetailedView -> FC -
#86705
PluginDetailedView -> FC -
#86699
SentryAppDetailedView -> FC -
#86895
IntegrationDetailedView -> FC -
#86954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants