-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add linux binaries to release build #1505
base: master
Are you sure you want to change the base?
Conversation
I think we should just add GNUInstallDirs in the CMakeLists.txt, that way distributors can configure the paths they want to install the files. |
will look into that tomorrow |
99b7d15
to
3f008ca
Compare
3f008ca
to
a150e6b
Compare
update: The cuda toolkit install now nukes the github action runners. they use too much disk space. |
Maybe we can keep just one CUDA version? |
I think 1 runner does 1 job at a time. So I don't think that would make a difference. also, I once before saw a gh workflow where some non essentials where deleted, to make some space... |
dad9e66
to
fafc8ae
Compare
OK, managed to download everything and even run main but I get this error:
This is with release fafc8ae and the CUDA 12 version. The machine also had 12 and 2080 Ti. |
fafc8ae
to
d9f3846
Compare
@SlyEcho btw, I switched to the "networked" installer, which is just setting up an apt repo ...
this looks very weird, no idea what is happening here. since I don't use |
a6c5f59
to
e344540
Compare
Isn’t there an image with CUDA already installed? I plan to go with that approach for ROCm. |
Image, hmm. installing cuda now only takes as long as the compile ~1min. so i dont really see the point of using docker (im assuming thats what you mean with image) |
this made installing not the full toolkit viable (without me manually installing the apt sources 😄 ) |
Yeah, I meant Docker. AMD publishes their images with everything installed already. Although I don’t know if it’s possible to redistribute some of those runtime components |
It would be cool for windows build, those take for ever. but for linux builds is now <50% of total build time. there is still the problem of distributing the binaries NOT every release, those uploads now take up a significant amount of time (comparatively) |
b41deaf
to
ed418de
Compare
ed418de
to
fc60a27
Compare
c5d7b68
to
20f7f4c
Compare
5562e3e
to
cec628e
Compare
adds ubuntu20.04 binaries to the releases.
and also cublas linux builds.
I changed the path for where the dynamic library is put. It was in the cmake build directory before, now its next to the executables (down into bin/).
I always build shared, with relative rpath (so no
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:.
for libllama.so)Distributing the lib makes the life for wrappers (eg python libs) easier.
not in release yet:
example release: https://github.com/Green-Sky/llama.cpp/releases/tag/ci_cublas_linux-e344540