llava : use logger in llava-cli #6797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes printf() logging so llava-cli is shell scriptable.
|
👋 Forgive my ignorance 😄 How is that different? What's wrong with |
ggerganov
approved these changes
Apr 21, 2024
|
@dagelf in most cases llava was actually logging to stdout. |
okuvshynov
pushed a commit
to okuvshynov/llama.cpp
that referenced
this pull request
Apr 22, 2024
This change removes printf() logging so llava-cli is shell scriptable.
|
@jart this break rocm compile on windows |
|
W:/git/llama.cpp/common/.\log.h:300:48: warning: token pasting of ',' and
__VA_ARGS__ is a GNU extension [-Wgnu-zero-variadic-macro-arguments]
#define LOG(str, ...) LOG_IMPL("%s" str, "", ##__VA_ARGS__, "")
clang issues.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes printf() logging so llava-cli is shell scriptable.