-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Schema to GBNF integration tests #7790
Merged
HanClinto
merged 7 commits into
ggml-org:master
from
HanClinto:tests-json-schema-integration
Jun 22, 2024
+580
−21
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2b174dd
Adding simple bare-bones test for end-to-end integration test for jso…
HanClinto 74985de
Adding additional examples as documented in #7789 . Also adding the a…
HanClinto acd3c46
Uncommenting formerly commented tests so that they fail for others wh…
HanClinto d4a63b0
Merging improved schema test methods added by @ochafik in #7797
HanClinto 939b58a
Adding #define to temporarily remove failing tests so that this PR ca…
HanClinto 3bdf7c3
Fixing nits from ochafik. Removing escape slashes, adding additional …
HanClinto 5d15dc8
Fixing grammar indentation to be consistent throughout file.
HanClinto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Adding #define to temporarily remove failing tests so that this PR ca…
…n pass CI, but still be useful for other PRs that want to leverage the framework.
commit 939b58ae6bca5dbf4e822a97eb7ea9af82148616
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing these!
I would just move them down to the failed branch (w/ caveat header), hopefully I'll move them back up very soon :-) (not a fan of
#ifdef
dead code)