json: skip slow tests when running under emulator #8189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
|
I think this solution is good enough, the test is still fully run in the other platforms and it is extremely unlikely that it would fail only on AVX512. |
|
Just verified it's indeed skipped here and not in its sibling jobs: |
ochafik
changed the title
slaren
approved these changes
Jun 28, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jun 30, 2024
MagnusS0
pushed a commit
to MagnusS0/llama.cpp-normistral-tokenizer
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid tests timing out in AVX-512 emulation (see #8133 (comment), cc/ @slaren )
More proper fixes could be to split the json test in 3 (C++, Python, Node) and run them in parallel w/
ctest -j, and avoid the excessive subprocess calls to Python & Node.We could write test orchestration of each variant in its respective language, but we'd then need to share the test cases between the 3, say in JSON (may make their maintenance less easy than with the current C++ multiline support).
We could also launching Python & Node mini subprocess servers that serve a "/convert-schema-to-grammar" RPC (Yes, it sounds overengineered, but maybe it's the simplest change :-))
cc/ @HanClinto wdyt?