llama : update Swift and Android bindings for refactor sampling #8651
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HanClinto
changed the title
ggerganov
approved these changes
Jul 24, 2024
|
Great! Feel free to merge this when ready |
HanClinto
merged commit a352ad4
into
ggml-org:gg/llama-refactor-sampling
51 of 53 checks passed
ggerganov
pushed a commit
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be clear, this PR is opened as an amendment to #8643, not to master.
Feel free to ignore if this isn't helpful for you @ggerganov, but I updated the Swift and Android bindings for your refactor so that it will (hopefully) pass CI now.
Please ignore if not useful or if it's redundant for what you've already done locally -- I mainly wanted to use this as an experiment to test out your new changes and see how well it felt.
Overall it feels good! I only actually ran the
batched.swiftexample, but it seemed to run just fine and gave me sane outputs, so I assume the others will work alright too.Thanks!