Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: link to sha256sums file #902

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

NicoWeio
Copy link
Contributor

This is to emphasize that these do not need to be obtained from elsewhere.

This is to emphasize that these do not need to be obtained from elsewhere.
@Technetium1
Copy link

I like this change, but the URL generated is not okay in rich diff, it goes to this invalid place:
https://github.com/ggerganov/llama.cpp/blob/link-checksums/SHA256SUMS
For this reason, probably should directly link to it:
https://github.com/ggerganov/llama.cpp/blob/master/SHA256SUMS

@NicoWeio
Copy link
Contributor Author

I think this indeed only affects the preview (rich diff). If you use the link in https://github.com/NicoWeio/llama.cpp/blob/link-checksums/README.md, for example, it works just fine.
Sure, one could insert the full GitHub link, but this would prevent folks from opening the local checksum file right in their local editor, put a kind of hardlink to the base repo into forks, and possibly make the link go across branches (or break it). Apart from fixing the preview, I don't see any advantage. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants