You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the name property of a column definition is not a text but rather an HTML Element and then using a Column Picker or Grid Menu, the header title pulled from the name property is not being recreated properly
Reproduction
When using Column Picker or Grid Menu and unselecting any column from Example 16, the "Description" disappears completely.
this.columnDefinitions=[{// `name` can be a DOM element with a `title` to use as tooltip textid: 'desc',name: createDomElement('span',{title: 'custom title tooltip text',textContent: 'Description'}),field: 'description'}];
Which Framework are you using?
Vanilla / Plain JS
Environment Info
| Executable | Version || ------------------- | ------- || (framework used) | VERSION || Slickgrid-Universal | VERSION || TypeScript | VERSION || Browser(s) | VERSION || System OS | VERSION |
- fixes#1605 by reverting #1476
- this PR fixes#1605 without regressing on older issue #1475
- also add a `columnPickerLabel` option in the Column interface, because in some cases the default header column extractor (defined in the global grid options) will return all text it finds (via `.textContent`) and that might not be ideal given that an HTML element with extra button will also extract and append the button text in both ColumnPicker/GridMenu
Describe the bug
When the
name
property of a column definition is not a text but rather an HTML Element and then using a Column Picker or Grid Menu, the header title pulled from thename
property is not being recreated properlyReproduction
When using Column Picker or Grid Menu and unselecting any column from Example 16, the "Description" disappears completely.
Which Framework are you using?
Vanilla / Plain JS
Environment Info
Validations
The text was updated successfully, but these errors were encountered: