Remove disk_partitions() maxfile and maxpath fields
#2405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giampaolo
changed the title
maxfile and maxpath fields
This was referenced Apr 17, 2024
ddelange
added a commit
to ddelange/psutil
that referenced
this pull request
May 16, 2024
* 'master' of https://github.com/giampaolo/psutil: fix ruff errs skip flaky test on netbsd giampaolo#2408: fix some tests which were still failing due to the old name giampaolo#2408: ignore old "connections" name into as_dict() Rename `Process.connections()` to `Process.net_connections()` (giampaolo#2408) Remove disk_partitions() `maxfile` and `maxpath` fields (giampaolo#2405) Speedup process iter (don't check for PID reuse) (giampaolo#2404)
mcayanan
pushed a commit
to hysds/hysds
that referenced
this pull request
Jun 20, 2024
Due to psutil 6.0.0 release, it is found that it broke the instance_stats service with the following error:
```
Traceback (most recent call last):
File "/export/home/hysdsops/mozart/ops/hysds/scripts/log_instance_stats.py", line 119, in <module>
daemon(args.redis_url, args.redis_key, args.interval)
File "/export/home/hysdsops/mozart/ops/hysds/scripts/log_instance_stats.py", line 79, in daemon
for device, mnt_point, fs_type, fs_opts, max_file, max_path, *other in psutil.disk_partitions():
ValueError: not enough values to unpack (expected at least 6, got 4)
```
According to the psutil pull request, giampaolo/psutil#2405, max_file and max_path were removed because if there's a NFS (network filesystem) this function can potentially take a long time to complete.
mcayanan
added a commit
to hysds/hysds
that referenced
this pull request
Jun 20, 2024
* hot-fix: Update return from psutil.disk_partitions function
Due to psutil 6.0.0 release, it is found that it broke the instance_stats service with the following error:
```
Traceback (most recent call last):
File "/export/home/hysdsops/mozart/ops/hysds/scripts/log_instance_stats.py", line 119, in <module>
daemon(args.redis_url, args.redis_key, args.interval)
File "/export/home/hysdsops/mozart/ops/hysds/scripts/log_instance_stats.py", line 79, in daemon
for device, mnt_point, fs_type, fs_opts, max_file, max_path, *other in psutil.disk_partitions():
ValueError: not enough values to unpack (expected at least 6, got 4)
```
According to the psutil pull request, giampaolo/psutil#2405, max_file and max_path were removed because if there's a NFS (network filesystem) this function can potentially take a long time to complete.
* bump version
---------
Co-authored-by: Mike Cayanan <[email protected]>
mcayanan
added a commit
to hysds/hysds
that referenced
this pull request
Mar 10, 2025
* hot-fix: Update return from psutil.disk_partitions function
Due to psutil 6.0.0 release, it is found that it broke the instance_stats service with the following error:
```
Traceback (most recent call last):
File "/export/home/hysdsops/mozart/ops/hysds/scripts/log_instance_stats.py", line 119, in <module>
daemon(args.redis_url, args.redis_key, args.interval)
File "/export/home/hysdsops/mozart/ops/hysds/scripts/log_instance_stats.py", line 79, in daemon
for device, mnt_point, fs_type, fs_opts, max_file, max_path, *other in psutil.disk_partitions():
ValueError: not enough values to unpack (expected at least 6, got 4)
```
According to the psutil pull request, giampaolo/psutil#2405, max_file and max_path were removed because if there's a NFS (network filesystem) this function can potentially take a long time to complete.
* bump version
---------
Co-authored-by: Mike Cayanan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Removes
maxfileandmaxpathfields from the namedtuple returned bydisk_partitions(). Reason: if there's a NFS (network filesystem) this function can potentially take a long time to complete.