Git diff view persists after pressing Ctrl+C to exit

[dkaksl]

• I was not able to find an open or closed issue matching what I'm seeing

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

64-bit

$ git --version --build-options
git version 2.9.0.windows.1

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

7

$ cmd.exe /c ver

Microsoft Windows [Version 6.1.7601]

• What options did you set as part of the installation? Or did you choose the
  defaults?

Probably defaults. I'm using git-for-windows that comes bundled with Cmder.

• Any other interesting things about your environment that might be related
  to the issue you're seeing?

I am specifically running the git-for-windows binary from cmd, so this is probably not a cmder isolated issue.

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

CMD

• What commands did you run to trigger this issue? If you can provide a
  Minimal, Complete, and Verifiable example
  this will help us understand the issue.

Steps to reproduce

1. Make some changes to any version controlled file (changes should be long enough to stay in scrollable diff view)
2. git diff
3. Ctrl + C
4. Press Enter multiple times

• What did you expect to occur after running these commands?

Exit diff view. If that fails, to exit it when Q is subsequently pressed.

• What actually happened instead?

Every second press of Enter brings back a diff view prompt : and Q does not allow the shell to exit.

[dscho]

This issue may be fixed in a more current version. Could you give the current snapshot a try?

[dscho]

I take that as a yes.

[dkaksl]

Just tested it now. No it is not fixed.

Every second Ctrl + C press brings back the diff view prompt :.

This persists even after executing exit to close the git shell.

[dscho]

This persists even after executing exit to close the git shell.

Wait. What "git shell" do you close that does not close the window?

Your bug report specified very clearly that you run this in CMD, and there was no description of any "git shell" whatsoever.

[dkaksl]

@dscho the "git shell" is the interface you get from running git-cmd.exe in CMD

You then execute exit once to go back to the normal CMD interface (without the git commands).

[dkaksl]

@dscho is it possible for you to just try it yourself? It took me like 5 minutes from downloading the latest snapshot.

[dscho]

the "git shell" is the interface you get from running git-cmd.exe in CMD

You then execute exit once to go back to the normal CMD interface (without the git commands).

That is not how you are supposed to use this. Either call Git CMD from the Start Menu, or call git-cmd.exe from the Windows Explorer or Windows+R prompt.

Calling Git CMD from within CMD is not really supported, it is hard enough to support Git CMD as-is...

[dkaksl]

Just tested on the latest snapshot, again, as you described, running git-cmd.exe from Windows Explorer. It recreates.

[dscho]

@dkaksl there must be a missing piece of information, as I really cannot reproduce the described behavior here.

[dkaksl]

OK, let me try again and attach a gif maybe...

…

On May 29, 2017 23:20, "Johannes Schindelin" ***@***.***> wrote: @dkaksl <https://github.com/dkaksl> there must be a missing piece of information, as I really cannot reproduce the described behavior here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1113 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AISaaowUAAiFR6yXR5xUVi6YnfyaIqonks5r-uJPgaJpZM4Msk3W> .

[dscho]

For the record, I see no GIF. And I'd much rather have a detailed list of steps in accordance with http://stackoverflow.com/help/mcve and http://whathaveyoutried.com/.

[dkaksl]

I meant I would add a gif as soon as I have the opportunity. As for my instructions on recreating the issue, I'm not sure how I could write them more clearly.

…

On May 31, 2017 00:02, "Johannes Schindelin" ***@***.***> wrote: For the record, I see no GIF. And I'd much rather have a detailed list of steps in accordance with http://stackoverflow.com/help/mcve and http://whathaveyoutried.com/. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1113 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AISaag0u8YQkYQ-HWUO5RRBp_mIllg-_ks5r_D2AgaJpZM4Msk3W> .

[AraHaan]

I get this a lot on my end too making things much unreadable. I also noticed it happens more often on large doffs of like at least over 1k lines or so of changes. It also sometimes does it on small diffs though.

[dscho]

I am working on a fix for #1491 which should also address this here issue. Once a new snapshot becomes available at https://wingit.blob.core.windows.net/files/index.html, I invite you all to test it.