t: mark test sources as .PHONY #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation to mark test sources as .PHONY, let's keep track of a list of them so that we can eventually write: .PHONY : $(TEST_SRCS) In the meantime, we'll replace the pattern "./t-%.sh", which will not introduce a meaningful behavior change.
We have used 'make' in the testing directory 't' to help run integration tests, including starting and stopping a Git LFS test server, and environmental setup bits. We do so by writing a recipe that matches all testing files that we'd want to run, and then running commands based on which one we picked. Since we don't generate a file that was missing when running one of these sources, 'make' will say that the file is up-to-date, unless we run with 'make -B' (to force a re-make). This is annoying to type, and can be avoided by marking the test targets as .PHONY, indicating that they don't produce a file, and are instead synthetic targets that can be run repeatedly without `make`'s up-to-date checking.
|
Are you reading my mind? This is a feature I just needed today. |
bk2204
approved these changes
Sep 5, 2018
|
🔮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes
t/t-*.shtargets.PHONY, so that we can repeatedly invoke them asmake t-*.shwithout having to pass-B./cc @git-lfs/core