Uninstall improvements #3326
Merged
Uninstall improvements #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We provide a --system option for git lfs uninstall, but we forgot to document it. Do so to help people find it more easily.
When running git lfs uninstall --system, we would tell the user that the global (i.e., per-user) Git LFS configuration had been removed, even though we had in fact modified the system configuration and not the global one. Print the correct message so as not to confuse users.
git lfs install has a --skip-repo option, which prevents any attempt to modify the repo if run from within one. Add such an option for git lfs uninstall as well. Document it and add tests for its functionality.
|
Thanks for this! |
|
I'm not familiar with your release cadence. Will this be in a tagged release soon? If not I'm fine with adding it to Fedora's RPMs with a patch. |
We usually release a new 2.x.0 version every ~3 or so months. There should be one out next week, which will include this. |
|
Perfect, I won't bother with a local patch and just wait till next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series introduces a set of improvements to
git lfs uninstall. First, the--systemoption is documented. Second, we print a more accurate message about which configuration is modified when the--systemoption is provided. Finally, we add a--skip-repooption for parallelism withgit lfs install.I will admit that there is some slight duplication in 5541da6, but I was unable to find an elegant way to avoid it.
This series fixes #3322, fixes #3323, and fixes #3324.