Support pushInsteadOf aliases when determining endpoints #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a future commit, we're going to need to know the operation when performing Git URL replacement, so ensure that the operation is passed whenever we're creating an endpoint.
In a future commit, we're going to handle both regular and push aliases, so split the storage out into a separate function to avoid repetition. This commit should introduce no functional change.
In a future commit, we'll be replacing multiple types of aliases. Split out most of the URL alias replacement code into a separate function. Make that function additionally return a boolean indicating whether a replacement occurred. This commit should have no functional change.
For pushes, Git looks at both the insteadOf and pushInsteadOf aliases, and uses the latter in preference to the former. Teach Git LFS to honor pushInsteadOf as well when uploading.
ttaylorr
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git understands how to specify aliases that differ between fetch and pull by using
pushInsteadOfaliases. This series introduces support for this type of alias in Git LFS so that we can authenticate to the right endpoint when performing a push, as the user intended.The first patch updates various callers; the second and third patches split out functions and should have no functional changes. The fourth patch introduces the new alias support. Note that we use the same mutex for protecting all the aliases since there's no reason to distinguish between them.
This fixes #2433.