Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min java version to 1.8 #1218

Closed
paladox opened this issue Mar 18, 2017 · 6 comments
Closed

Bump min java version to 1.8 #1218

paladox opened this issue Mar 18, 2017 · 6 comments
Milestone

Comments

@paladox
Copy link
Contributor

paladox commented Mar 18, 2017

We should bump the min java version to 1.8 in the next release so we can bump jetty version and other deps and other deps which requires java 1.8+.

paladox added a commit to paladox/gitblit that referenced this issue Mar 18, 2017
@flaix
Copy link
Member

flaix commented Mar 18, 2017

I vote against it. I wouldn't want to force Java 8 as a requirement on users of Gitblit. Not just so that it can use the latest versions of whatever dependencies it has without reason.
Gitblit is a server application running on stable systems, not a game or desktop app running on the latest, greatest PC. Wide spread Linux server distributions like Debian Jessie or Ubuntu 14.04, for example still come with Java 7.

While there is merit in keeping up-to-date with dependencies, there should still be a good reason why an update is done, if the system currently is working. So updating all dependencies just because, and thereby stepping up the Java requirement, is not a good idea, I think.

@martinspielmann
Copy link
Contributor

I vote for java 8 as a minimal version. Java 9 is already released and Java 7 reached its public end of life long time ago. I just ran an OWASP-dependeny check against GitBlit source and the result was... improvable. From a security point of view, it would be good to have the chance to update to patched versions of dependencies. Stability could be ensured by raising test coverage... and maybe beta/milestone releases?

@flaix flaix added this to the 1.10.0 milestone Nov 10, 2019
@ghmer
Copy link

ghmer commented Jun 29, 2020

Given the time between releases, I vote for Java11. It is the actual LTS. Java 8 would have been an option 3 years ago.

@TomaszSzt
Copy link
Contributor

Voting for JDK 8 also. It is harder and harder to set-up build environment to use jdk7. Recently You must even keep two versions of ANT as only up to 1.9 allows to use pre 8 JDK what can be a real mess up.

@andrm
Copy link

andrm commented Nov 4, 2021

Voting for Java 11.

@flaix flaix closed this as completed in 3d42f7b Feb 6, 2022
@flaix
Copy link
Member

flaix commented Feb 6, 2022

From Gitblit version 1.10.0 on the minimum Java version is Java 8.

davidef pushed a commit to zero11it/gitblit that referenced this issue Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants